Skip to content

[CHIA-3712] simplify add_transaction() #20063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2025
Merged

[CHIA-3712] simplify add_transaction() #20063

merged 3 commits into from
Sep 16, 2025

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Sep 15, 2025

Purpose:

Collapse unnecessary catching and re-throwing of exceptions.
Introduce an early exit for when we're syncing, to reduce indentation.
Replace literals with the CONSENSUS_ERROR_BAN_SECONDS constant

fixup a test for farming blocks that under-estimates the block cost prior to the hard fork (we no longer support farming blocks before the hard fork).

@arvidn arvidn requested a review from a team as a code owner September 15, 2025 09:03
@arvidn arvidn changed the title simpliy add_transaction() [CHIA-3712] simplify add_transaction() Sep 15, 2025
@arvidn arvidn requested a review from AmineKhaldi September 15, 2025 09:03
@arvidn arvidn added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Sep 15, 2025
AmineKhaldi
AmineKhaldi reviewed Sep 15, 2025
View reviewed changes
AmineKhaldi
AmineKhaldi reviewed Sep 15, 2025
View reviewed changes
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Sep 15, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 17758307913

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 44 of 56 (78.57%) changed or added relevant lines in 4 files are covered.
  • 19 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.03%) to 91.267%
Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/server/server.py 5 7 71.43%
chia/full_node/full_node.py 27 37 72.97%
Files with Coverage Reduction New Missed Lines %
chia/wallet/util/wallet_sync_utils.py 1 85.57%
chia/util/files.py 2 91.38%
chia/full_node/full_node_api.py 3 85.6%
chia/rpc/rpc_server.py 3 88.4%
chia/server/node_discovery.py 3 82.29%
chia/server/server.py 3 83.83%
chia/wallet/wallet_node.py 4 87.13%
Totals Coverage Status
Change from base Build 17700259666: 0.03%
Covered Lines: 102832
Relevant Lines: 112538
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/full_node/full_node.py 73.0% lines 512, 514-515, 1104, 1107, 1122, 1125, 1387, 2780, 2800
chia/server/server.py 71.4% lines 561, 564
Total Missing Coverage
56 lines 12 lines 78%

wjblanke
wjblanke approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@pmaslana pmaslana merged commit 73cb547 into main Sep 16, 2025
383 of 386 checks passed
@pmaslana pmaslana deleted the add-transaction-cleanup branch September 16, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineKhaldi AmineKhaldi AmineKhaldi approved these changes

@wjblanke wjblanke wjblanke approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvidn @AmineKhaldi @wjblanke @pmaslana